I prefer hardware FXs on hardware synths if there are controls on it, because that will be next to the instrument I’m playing with.
It sounds also better to my ears for more extreme scenarios. If you need a bit of overdrive on your bassline, software is fine.
You should also define your budget, because there are a lot of options out there.